forked from MarkBind/markbind
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new question feature #1
Open
weiquu
wants to merge
30
commits into
master
Choose a base branch
from
branch_question
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new question type, the "multiple blanks" question type. Still some things to be added, such as support for multiple keywords, setting a threshold, and making blanks inline with the question.
Merging to remove package-lock.json changes
Co-authored-by: Ang Ze Yu <[email protected]>
Co-authored-by: Ang Ze Yu <[email protected]>
Co-authored-by: Ang Ze Yu <[email protected]>
Co-authored-by: Ang Ze Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Overview of changes:
Add a new question type, the
multiple blanks
question type. The syntax is very similar to other question types. An example is provided below:The result will look like this:
Anything you'd like to highlight/discuss:
Still some things to be added, such as support for multiple keywords, setting a threshold, and making blanks inline with the question.
Testing instructions:
Proposed commit message: (wrap lines at 72 characters)
Add new question type for questions with multiple blanks
Checklist: ☑️