🚨 Setup CI to run linting using cargo clippy

[weiji14]

Run cargo clippy --all-targets --all-features on Continuous Integration on every Pull Request and push to main.

TODO:

• Add clippy lint CI, adapted from https://doc.rust-lang.org/stable/clippy/continuous_integration/github_actions.html
• Fix clippy lints (do after some other refactoring is complete in other PRs):
  • clippy::wrong-self-convention - Fixed by renaming PyCogReader::to_numpy method to PyCogReader::as_numpy ( ⚠️ somewhat breaking change ), done in commit ef4cc71 and e5a9af2
  • clippy::type-complexity - Silenced in commit 9b220bc
  • clippy::needless-lifetimes - fixed in commit b1f8782
  • clippy::useless-conversion - fixed in commit b178519

[weiji14]

Copy of clippy lint errors from https://github.com/weiji14/cog3pio/actions/runs/12322416017/job/34395934063?pr=22#step:3:334:

error: useless conversion to the same type: `std::vec::Vec<T>`
  --> src/io/geotiff.rs:84:13
   |
84 |             image_data.into(),
   |             ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `image_data`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
   = note: `-D clippy::useless-conversion` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
error: methods with the following characteristics: (`to_*` and `self` type is not `Copy`) usually take `self` by reference
  --> src/python/adapters.rs:63:22
   |
63 |     fn to_numpy<'py>(&mut self, py: Python<'py>) -> PyResult<Bound<'py, PyArray3<f32>>> {
   |                      ^^^^^^^^^
   |
   = help: consider choosing a less ambiguous name
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention
   = note: `-D clippy::wrong-self-convention` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::wrong_self_convention)]`
error: very complex type used. Consider factoring parts into `type` definitions
  --> src/python/adapters.rs:77:10
   |
77 |     ) -> PyResult<(Bound<'py, PyArray1<f64>>, Bound<'py, PyArray1<f64>>)> {
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `-D clippy::type-complexity` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::type_complexity)]`
error: the following explicit lifetimes could be elided: 'py
   --> src/python/adapters.rs:154:12
    |
154 | fn cog3pio<'py>(_py: Python, m: &Bound<'py, PyModule>) -> PyResult<()> {
    |            ^^^                         ^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
    = note: `-D clippy::needless-lifetimes` implied by `-D warnings`
    = help: to override `-D warnings` add `#[allow(clippy::needless_lifetimes)]`
help: elide the lifetimes
    |
154 - fn cog3pio<'py>(_py: Python, m: &Bound<'py, PyModule>) -> PyResult<()> {
154 + fn cog3pio(_py: Python, m: &Bound<'_, PyModule>) -> PyResult<()> {
    |
error: could not compile `cog3pio` (lib) due to 4 previous errors
warning: build failed, waiting for other jobs to finish...
error: could not compile `cog3pio` (lib test) due to 4 previous errors
Error: Process completed with exit code 101.