Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Corrected jest update snapshot(s) cli flag back to -u #465

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

KemingHe
Copy link
Contributor

I made a mistake in previous commit when polishing the pnpm scripts. Now pnpm unit:test:update-snapshots will trigger the correct jest -u cli command to run unit tests and update snapshots. Apologies @wei .

Jest update flag is either -u or --updateSnapshot, to keep pnpm script consistency, revered back to -u.
Copy link

changeset-bot bot commented Dec 19, 2024

🦋 Changeset detected

Latest commit: 43e8b18

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
socialify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for github-socialify ready!

Name Link
🔨 Latest commit 43e8b18
🔍 Latest deploy log https://app.netlify.com/sites/github-socialify/deploys/6764586acdbd620008a5e6a0
😎 Deploy Preview https://deploy-preview-465--github-socialify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wei
Copy link
Owner

wei commented Dec 19, 2024

No worries, I see, -u is shortt for --updateSnapshot

@wei wei merged commit 791e6e7 into wei:master Dec 19, 2024
7 checks passed
@KemingHe KemingHe deleted the fix-jestupdatesnapshotcli-keminghe branch December 19, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants