-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Better warning for long logo data uri #440
Conversation
feat: handle long svg data uri
🦋 Changeset detectedLatest commit: d297354 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for github-socialify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slusy thanks for your PR! Please see comments above. and any way you can add a playwright test - you can write in Codespaces by click on "Code" dropdown on the PR?
refactor: svg uri error handling
@wei should I use the same strategy for playwright like other tests, like taking screenshots and comparing? |
Yes, screenshots for sure and please use your discretion to include additional tests as appropriate. |
test: playwright test for long svg data uri
refactor: input component and tests
78c7b24
to
d8ea1c8
Compare
d8ea1c8
to
d297354
Compare
@slusy made some final edits and just merged 🥳 Lines 3 to 9 in 811ccd2
|
Reference Issues / PRs
closes #419
What does this implement/fix?
Add error handling for long svg data uri inputs, also added unit tests for the same
Untitled.mov
Any other comments?
No