Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Better warning for long logo data uri #440

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

spudoodle
Copy link
Contributor

@spudoodle spudoodle commented Dec 13, 2024

Reference Issues / PRs

closes #419

What does this implement/fix?

Add error handling for long svg data uri inputs, also added unit tests for the same

Untitled.mov

Any other comments?

No

feat: handle long svg data uri
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: d297354

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
socialify Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Dec 13, 2024

Deploy Preview for github-socialify ready!

Name Link
🔨 Latest commit d297354
🔍 Latest deploy log https://app.netlify.com/sites/github-socialify/deploys/67611c9f78fb6c00087ccf54
😎 Deploy Preview https://deploy-preview-440--github-socialify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Owner

@wei wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slusy thanks for your PR! Please see comments above. and any way you can add a playwright test - you can write in Codespaces by click on "Code" dropdown on the PR?

src/components/configuration/config.tsx Outdated Show resolved Hide resolved
src/components/configuration/inputWrapper.tsx Outdated Show resolved Hide resolved
refactor: svg uri error handling
@spudoodle
Copy link
Contributor Author

@slusy thanks for your PR! Please see comments above. and any way you can add a playwright test - you can write in Codespaces by click on "Code" dropdown on the PR?

@wei should I use the same strategy for playwright like other tests, like taking screenshots and comparing?

@wei
Copy link
Owner

wei commented Dec 14, 2024

Yes, screenshots for sure and please use your discretion to include additional tests as appropriate.

test: playwright test for long svg data uri
@spudoodle spudoodle requested a review from wei December 14, 2024 08:12
src/components/configuration/configuration.test.tsx Outdated Show resolved Hide resolved
src/components/configuration/configuration.test.tsx Outdated Show resolved Hide resolved
src/components/configuration/config.tsx Outdated Show resolved Hide resolved
refactor: input component and tests
@spudoodle spudoodle requested a review from wei December 15, 2024 18:49
@wei wei changed the title 🥅 Feat: handle long svg data uri ✨ Better warning for long logo data uri Dec 17, 2024
@wei wei force-pushed the feat/handle-long-svg-data-uri branch from 78c7b24 to d8ea1c8 Compare December 17, 2024 06:37
@wei wei force-pushed the feat/handle-long-svg-data-uri branch from d8ea1c8 to d297354 Compare December 17, 2024 06:39
@wei wei enabled auto-merge (squash) December 17, 2024 06:41
@wei wei merged commit e7f708e into wei:master Dec 17, 2024
7 checks passed
@wei
Copy link
Owner

wei commented Dec 17, 2024

@slusy made some final edits and just merged 🥳

## 2.16.0
### Minor Changes
- e7f708e: Added error handling for long svg data uri input
Thanks to [slusy](https://github.com/slusy)

@spudoodle spudoodle deleted the feat/handle-long-svg-data-uri branch December 17, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display error for long svg data uri
2 participants