Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: Rich Text list item support #4633

Merged
merged 5 commits into from
Dec 21, 2024
Merged

experimental: Rich Text list item support #4633

merged 5 commits into from
Dec 21, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 21, 2024

Description

ref #4595

Bugs

  • - Empty list items are not considered as editable

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov mentioned this pull request Dec 21, 2024
11 tasks
@istarkov istarkov marked this pull request as draft December 21, 2024 14:48
@istarkov istarkov requested review from kof and johnsicili December 21, 2024 15:52
@istarkov istarkov marked this pull request as ready for review December 21, 2024 15:53
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

I think it's a bit unintuitive to get out of the list. ie you have to use slash at the end.

Would be nice to auto exit after entering within an empty list item.

  1. hello (now I hit enter)
  2. (I hit enter again and this gets removed and p gets added)

@istarkov
Copy link
Member Author

Moved here #4595
image

@istarkov istarkov merged commit 1670ea5 into main Dec 21, 2024
15 checks passed
@istarkov istarkov deleted the list-item branch December 21, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants