-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: RichText edit / command menu #4621
Conversation
Content Feedback @istarkov
|
4 is the biggest feedback so let me explain. I think we should use "enter" instead of "slash". Slash is a really great command, but in every implementation of it that I've seen, you use it on a blank line, which is essentially a paragraph. For our implementation, we are using it to add a new block. The difference is in the common implementation of it, slash is used to convert blank lines, which are paragraphs, to another element. In our implementation, slash is used to create a new line and component at the same time. So I think unless we have a paragraph by default on enter, then "Enter" should be used to add something new. Type, enter, add component. Also, typing slash within existing content feels odd. Just a little video show how slash is used on new lines: |
Description
ref #4595
Search is working
Arrow keys, enter, mouse click is working.
https://p-15889dd9-ed47-46db-9411-fa18c1efb2fe-dot-edit.development.webstudio.is/
/blabla
Steps for reproduction
Code Review
Before requesting a review
Before merging
.env
file