build: Release 16-12-2024 #4597
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
force-pushed
the
release-16-12-2024.staging
branch
from
4408d7a to
77076a4
Compare
Ref https://discord.com/channels/955905230107738152/1318292995023306803/1318292995023306803 Here removed constraints for dialog title and dialog description in dialog content. Users often delete them though radix starts throwing warnings about it for a while now.
See https://discord.com/channels/955905230107738152/1318274135679438959/1318274135679438959 With undo current selected pages can be deleted though we do not have a logic reverting selected page or instance. So here is quick fix to always fallback to home page if pageId in url references missing page.
Forgot we have markdown embed. Now everything should work well.
…rrent' is not a valid selector.
## Description - background content toggle group width of the buttons - commands ui input vertical alignment - extracted controlHeight into theme, because 24px height for all controls is our main value ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Looks like parent/child constraints will work only for tags and not for components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile