Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove assetBaseUrl from image loaders #4569

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

TrySound
Copy link
Member

Asset base url is now automatically added by builder or component generator and passed to loader as is.

Saas loader removes /cgi/asset when detected.
All other loaders just use full relative path without changes which simplifies them a lot.

Asset base url is now automatically added by builder or component generator
and passed to loader as is.

Saas loader removes /cgi/asset when detected.
All other loaders just use full relative path without changes
which simplifies them a lot.
@TrySound TrySound requested a review from istarkov December 12, 2024 07:39
@TrySound TrySound merged commit a82ee06 into main Dec 12, 2024
27 checks passed
@TrySound TrySound deleted the asseturl.staging branch December 12, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants