New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: NO INP branch for comparison #4561

Closed

istarkov wants to merge 1 commit into main from noinp.staging

Member

istarkov commented Dec 11, 2024

Description

What is this PR about (link the issue and add a short description)

Steps for reproduction

click button
expect xyz

Code Review

hi @kof, I need you to do
- conceptual review (architecture, feature-correctness)
- detailed review (read every line)
- test it on preview

Before requesting a review

made a self-review
added inline comments where things may be not obvious (the "why", not "what")

Before merging

tested locally and on preview environment (preview dev login: 0000)
updated test cases document
added tests
if any new env variables are added, added them to .env file


          Empty

a06f79e

istarkov closed this

istarkov deleted the noinp.staging branch

December 12, 2024 13:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet