feat: Experimental INP fix #4560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kof
approved these changes
Dec 12, 2024
istarkov
added a commit
that referenced
this pull request
Dec 12, 2024
## Description https://vercel.com/blog/demystifying-inp-new-tools-and-actionable-insights ## new https://inp-inp-inp-inp.wstd.work/ ## prev https://no-inp-no-no.wstd.work/ ## 20x slowdown new (click) <img width="323" alt="image" src="https://github.com/user-attachments/assets/08b063f6-93a3-4e2b-8e5d-e9521f97a40d" /> ## 20x slowdown new (keyboard) <img width="305" alt="image" src="https://github.com/user-attachments/assets/3a1bb563-392f-40d9-9067-7cb085adcedd" /> ## 20x slowdown old (click) <img width="308" alt="image" src="https://github.com/user-attachments/assets/41ff36cd-bd27-4e5d-b569-9040ce12b845" /> ## 20x slowdown old (keyboard) <img width="304" alt="image" src="https://github.com/user-attachments/assets/4cc41ef9-f6d1-4e2a-ad41-de601d713bc9" /> ## Steps for reproduction 1. click button 2. expect xyz ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 0000) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://vercel.com/blog/demystifying-inp-new-tools-and-actionable-insights
new
https://inp-inp-inp-inp.wstd.work/
prev
https://no-inp-no-no.wstd.work/
20x slowdown new (click)
20x slowdown old (click)
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile