Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create xml-time component to convert time to iso string in xml documents #4515

Merged
merged 3 commits into from
Dec 5, 2024
Merged

feat: Create xml-time component to convert time to iso string in xml documents #4515

merged 3 commits into from
Dec 5, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Dec 5, 2024 •
edited
Loading

Description

image

Tested with fixtures.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 0000)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from kof December 5, 2024 12:55
@istarkov istarkov merged commit 7975fce into main Dec 5, 2024
27 checks passed
@istarkov istarkov deleted the time.staging branch December 5, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istarkov @kof @TrySound