Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

experimental: support nested and attribute selectors #4213

Merged
merged 6 commits into from
Oct 4, 2024
Merged

experimental: support nested and attribute selectors #4213

merged 6 commits into from
Oct 4, 2024

Conversation

kof
Copy link
Member

@kof kof commented Oct 4, 2024

Description

Needed to support all wf presets for fixing this #4155

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound October 4, 2024 00:16
@kof kof merged commit da7e9cd into main Oct 4, 2024
15 checks passed
@kof kof deleted the css-nesting branch October 4, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @TrySound