Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix scrolling for some users on Windows 10 + Chrome 129 #4163

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Conversation

kof
Copy link
Member

@kof kof commented Sep 25, 2024

Closes #4128

Description

should fix both: style panel and canvas scrolling

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@johnsicili johnsicili self-requested a review September 25, 2024 16:59
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

Tested on Windows Chrome and Edge with and without GPU acceleration and on a page with and without a background.

Also tested on Mac Brave.

Good stuff!

@kof kof requested a review from istarkov September 25, 2024 17:03
@kof kof merged commit ae287ab into main Sep 25, 2024
17 checks passed
@kof kof deleted the fix-scroll branch September 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows can't scroll body on canvas without background color
3 participants