Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Tooltip delay removed when doing things other than hovering over tooltip trigger #4162

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix: Tooltip delay removed when doing things other than hovering over tooltip trigger #4162

merged 1 commit into from
Sep 25, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented Sep 25, 2024 •
edited
Loading

Description

closes #3477

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov requested a review from johnsicili September 25, 2024 16:07
johnsicili
johnsicili approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@johnsicili johnsicili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go!! The cases I know work now.

Just to note, maybe something separate, when hovering over one to trigger it, quickly going to another tooltip has zero delay. May be intentional

tooltip.mp4

@istarkov istarkov changed the title fix: Tooltip delays fix: Tooltip delay removed when doing things other than hovering over tooltip trigger Sep 25, 2024
@istarkov istarkov requested a review from kof September 25, 2024 16:45
@istarkov istarkov merged commit 329ddea into main Sep 25, 2024
19 checks passed
@istarkov istarkov deleted the tooltip-delay branch September 25, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsicili johnsicili johnsicili approved these changes

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip delay removed when doing things other than hovering over tooltip trigger
3 participants
@istarkov @kof @johnsicili