fix: Resolve failing database tests on production environment #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
TrySound
approved these changes
Sep 24, 2024
istarkov
added a commit
that referenced
this pull request
Sep 25, 2024
## Description closes #2644 - [x] - Merge this #4156 into this PR - If the user has no custom domains: - [x] Checkbox for Pro users is not shown. - [x] Checkbox for Free users is shown but disabled (Tooltip enabled). - If the user has custom domains: - No Pro: - [x] Checkboxes are shown disabled with Tooltips. - Pro: - Users can select any checkbox (no Tooltips). - Current indexing logic: - If a user has custom domain(s), upon publishing, the `*.wstd.io` domain will receive the meta tag: ```html <meta name="robots" content="noindex, nofollow"> ``` - [x] - Fix example.com in tests (NEXT PR #4156) - [ ] - saas cleanup should be changed (we need to preserve latest build by domain now) (NEXT PR) - [x] - Disable Publish Button if no checkboxes are selected - "With the Pro, you’ll gain the ability to publish to each domain independently!" <img width="477" alt="image" src="https://github.com/user-attachments/assets/105577e5-318f-4146-a3eb-38c2117f6f79"> ## Steps for reproduction ### Non Pro - Login as a new non Pro User `pass:[email protected]` - Create a new Project, Click Publish. Expect Disabled Checkbox with Tolltip is visible. Publish is Enabled. <img width="445" alt="image" src="https://github.com/user-attachments/assets/e48654af-1969-4f96-b048-a3fa72303b8f"> - Publish, check it published. - Add custom domain, Publish, check both are published. ### Pro - Login as a Pro User `pass` - Open new Project. Expect No checkbox. One wstd domain. <img width="351" alt="image" src="https://github.com/user-attachments/assets/c62f9ae5-669a-46ad-a2f2-32ba333068f9"> - Publish. Expect it published. - Add domain. See checkboxes visible after domain activated. - Publish. Expect both published. - Uncheck checkboxes, see publish button disabled. See it has tooltip. ## Code Review - [ ] hi @kof, I need you to do - conceptual review (architecture, feature-correctness) - detailed review (read every line) - test it on preview ## Before requesting a review - [ ] made a self-review - [ ] added inline comments where things may be not obvious (the "why", not "what") ## Before merging - [ ] tested locally and on preview environment (preview dev login: 5de6) - [ ] updated [test cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md) document - [ ] added tests - [ ] if any new env variables are added, added them to `.env` file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prev PR #4143
Steps for reproduction
Code Review
Before requesting a review
Before merging
.envfile