-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add modern system font stacks #4123
Conversation
Items are not checked on first click, only on second one Screen.Recording.2024-09-16.at.18.51.01.mov |
Might be good to use a settings icon instead of upload. These fonts are very useful without having to upload and the icon doesnt communicate that |
The component we use there has been deprecated, its an old behavior, won' be fixingit |
There isn't much to say, is three? same for others |
turns out this bug is already in prod |
I was unaware that we need to specify fonts to display emojis. I still am not sure that it is needed. So I guess the tooltip would clarify this :) |
select still doesn't work on first click |
@johnsicili actually I just realized emoji fonts were not meant to be used standalone as a font, they are meant to be added to any of the font stacks if you want the emojis to use these fonts https://github.com/system-fonts/modern-font-stacks?tab=readme-ov-file#emoji-support In theory, we need to add these to every stack basically |
Deleted emoji stack, don't see the need for it, as in the OSs, fallbacks are alredy in-place |
Otherwise good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. small stuff just fyi feel free to merge up to you
Closes #4121
Description
We discovered this repository of awesome system fonts with fallbacks, well organized.
https://github.com/system-fonts/modern-font-stacks
Assumption here is that most people don't actually need a very specific font rendered, but rather need a type of a font and they are perfectly fine with fallbacks, but without this awesome, tested fallbacks list, how can you know which fallback to use.
With this we will encourage more people to use system fonts.
Steps for reproduction
Code Review
Before requesting a review
Before merging
.env
file