Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release-01-08-2024 #3912

Closed
wants to merge 7 commits into from
Closed

build: release-01-08-2024 #3912

wants to merge 7 commits into from

Conversation

kof
Copy link
Member

@kof kof commented Aug 9, 2024

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof temporarily deployed to postgres_production August 9, 2024 21:32 — with GitHub Actions Inactive
@kof kof temporarily deployed to development August 9, 2024 22:26 — with GitHub Actions Inactive
@kof kof temporarily deployed to postgres_production August 9, 2024 22:26 — with GitHub Actions Inactive
@kof kof had a problem deploying to postgres_production August 9, 2024 22:40 — with GitHub Actions Failure
@kof kof temporarily deployed to development August 9, 2024 22:40 — with GitHub Actions Inactive
@kof kof temporarily deployed to postgres_production August 9, 2024 22:43 — with GitHub Actions Inactive
@kof kof had a problem deploying to postgres_production August 9, 2024 22:58 — with GitHub Actions Failure
@kof kof temporarily deployed to development August 9, 2024 22:58 — with GitHub Actions Inactive
@kof kof temporarily deployed to postgres_production August 9, 2024 23:00 — with GitHub Actions Inactive
@istarkov istarkov had a problem deploying to postgres_production August 10, 2024 05:53 — with GitHub Actions Failure
@istarkov istarkov temporarily deployed to postgres_production August 10, 2024 05:55 — with GitHub Actions Inactive
@istarkov istarkov had a problem deploying to postgres_production August 10, 2024 10:26 — with GitHub Actions Failure
@istarkov istarkov temporarily deployed to postgres_production August 10, 2024 10:26 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_production August 10, 2024 10:28 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_production August 10, 2024 10:29 — with GitHub Actions Inactive
@kof kof closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kof @istarkov