Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Release 30.07.2024 #3822

Closed
wants to merge 7 commits into from
Closed

build: Release 30.07.2024 #3822

wants to merge 7 commits into from

Conversation

istarkov
Copy link
Member

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov changed the title release build: Release 30.07.2024 Jul 30, 2024
@istarkov istarkov temporarily deployed to postgres_production July 30, 2024 09:49 — with GitHub Actions Inactive
@istarkov istarkov temporarily deployed to postgres_production July 30, 2024 09:50 — with GitHub Actions Inactive
@TrySound
fix: clone projects with preview images properly (#3825)
fe8e8de 
Fixes #3823

This fixes the issue with preview images set before assets are copied to
the new project.
@TrySound TrySound temporarily deployed to postgres_production July 30, 2024 11:29 — with GitHub Actions Inactive
@TrySound TrySound temporarily deployed to postgres_production July 30, 2024 11:48 — with GitHub Actions Inactive
@TrySound TrySound temporarily deployed to postgres_production July 30, 2024 11:49 — with GitHub Actions Inactive
@TrySound
fix: handle empty action in webhook form (#3827)
fb72b22 
Closes #3826

When user deleted action prop was still converted to resource but
resource itself was not created.
@TrySound
fix: delete projects with space in the end (#3828)
5ea40b0 
Here fixed deleting projects with space in the end. Also trimmed spaces
in titles when create new projects.
@TrySound TrySound temporarily deployed to postgres_production July 30, 2024 13:05 — with GitHub Actions Inactive
@TrySound
fix: resolve conflicts in variabld and class names (#3839)
ca0621d 
Fixes #3837

This fixes the issue with duplicating classes for different instances.
Affected both atomic and non-atomic styles because non-atomic class is
used as identifier internally.
@TrySound TrySound temporarily deployed to postgres_production July 31, 2024 08:46 — with GitHub Actions Inactive
@TrySound TrySound closed this Aug 1, 2024
@TrySound TrySound deleted the release-30-07-2024.staging branch August 1, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@istarkov @TrySound