Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move transforms section behind a flag #3810

Merged
merged 1 commit into from
Jul 28, 2024
Merged

chore: move transforms section behind a flag #3810

merged 1 commit into from
Jul 28, 2024

Conversation

JayaKrishnaNamburu
Copy link
Contributor

Description

This PR moves the transforms section behind a feature flag. The section needs to add tooltips for all properties and scale need to have a lock behaviour between the scaleX and scaleY properties.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)

@JayaKrishnaNamburu JayaKrishnaNamburu requested a review from kof July 28, 2024 12:24
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this Jul 28, 2024
@JayaKrishnaNamburu JayaKrishnaNamburu merged commit d56df60 into main Jul 28, 2024
13 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the feature-flag-transforms branch July 28, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kof kof kof approved these changes

Assignees

@JayaKrishnaNamburu JayaKrishnaNamburu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JayaKrishnaNamburu @kof