Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure AI doesn't return json markdown #3809

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Conversation

kof
Copy link
Member

@kof kof commented Jul 28, 2024

Description

Detect route started returning json in markdown instead of pure json json\n[\"generate-template-prompt\"]\n

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound July 28, 2024 12:05
@kof kof merged commit e0552f0 into main Jul 28, 2024
13 checks passed
@kof kof deleted the improve-AI-action-detection branch July 28, 2024 12:26
kof added a commit that referenced this pull request Jul 28, 2024
## Description

Detect route started returning json in markdown instead of pure json
`json\n[\"generate-template-prompt\"]\n`

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants