Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Skip empty combo class when pasting from webflow #3755

Merged
merged 2 commits into from
Jul 19, 2024
Merged

Conversation

kof
Copy link
Member

@kof kof commented Jul 18, 2024

Description

Skipping unnecessary combo class

Steps for reproduction

  1. in webflow, add element with class .a, define color
  2. add element with class .b, define font size
  3. add element with class .a.b don't define anything
  4. paste .a.b into webstudio - see .a .b tokens are added, but no .a.b

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@kof kof requested a review from TrySound July 18, 2024 21:07
@kof kof changed the title Fix: Skip empty combo class when pasting from webflow fix: Skip empty combo class when pasting from webflow Jul 18, 2024
@kof kof force-pushed the paste-from-webflow branch from 613b8a5 to 276dae1 Compare July 18, 2024 21:21
@kof kof temporarily deployed to development July 18, 2024 21:21 — with GitHub Actions Inactive
@kof kof temporarily deployed to development July 19, 2024 11:25 — with GitHub Actions Inactive
@kof kof merged commit 30c7600 into main Jul 19, 2024
13 checks passed
@kof kof deleted the paste-from-webflow branch July 19, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants