-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: add transform section under style-panel with ui controls #3718
Conversation
apps/builder/app/builder/features/style-panel/sections/transforms/transfor-panel.tsx
Outdated
Show resolved
Hide resolved
apps/builder/app/builder/features/style-panel/sections/transforms/transfor-panel.tsx
Outdated
Show resolved
Hide resolved
You can test the basic flow here @kof @TrySound there are definitely some UI changes and some code changes after merging with The one thing that i think needs some attention is, should we add default values for all the transforms properties when they click "+" at the top of the section. And what happens when they are all added, because if they click again. It gets reset. How can we show the Screen.Recording.2024-07-15.at.2.39.34.PM.mov |
I have update the UX now, to follow the dropdown approach for adding individual transform properties and not everything at once. If the UX is looking good, let me know. I need to test things out once and write tests for the utils. And in the next MR, i will go for Screen.Recording.2024-07-17.at.1.54.28.PM.mov |
Yeah, reagarding the broken icon. I tried re-exporting from figma several times. It still rendering as this. Any ideas on that ? |
Please update all icons from here, when icon is not added to icons, never use it, it can have all kinds of unfinished stuff, we forgot to do it https://www.figma.com/design/sfCE7iLS0k25qCxiifQNLE/%F0%9F%93%9A-Webstudio-Library?node-id=2-1406&t=ZLITg8pprIprkKfb-0 |
Updated icons in the design doc as well |
apps/builder/app/builder/features/style-panel/sections/transforms/transform-panel.tsx
Outdated
Show resolved
Hide resolved
apps/builder/app/builder/features/style-panel/sections/transforms/transform-panel.tsx
Outdated
Show resolved
Hide resolved
packages/css-data/src/property-parsers/rotate-properties-extractor.ts
Outdated
Show resolved
Hide resolved
packages/css-data/src/property-parsers/rotate-properties-extractor.ts
Outdated
Show resolved
Hide resolved
packages/css-data/src/property-parsers/skew-properties-extractor.ts
Outdated
Show resolved
Hide resolved
I see
the fixtures project is updated. Someone should commit the updated |
Description
Adds the primary
translate
,scale
,rotate
, skew` properties under transform section. Related to #3411Steps for reproduction
Todo
isExperiemental
flag need to be removed before merging the branch.Code Review
Before requesting a review
Before merging
.env
file