Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental: More comboclass fixes #3716

Merged
merged 2 commits into from
Jul 12, 2024
Merged

experimental: More comboclass fixes #3716

merged 2 commits into from
Jul 12, 2024

Conversation

kof
Copy link
Member

@kof kof commented Jul 12, 2024

Description

Source order specificity in webflow is completely unpredictable. I am just trying to do a wild guess based on testing with relume what would be the right order.

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

kof added 2 commits July 12, 2024 00:44
in the hope that the source order specificity is right, but we actually don't know it, in wf you can create classes in any order and then create a combo, so its completely unpredictable
@kof kof requested a review from TrySound July 12, 2024 10:32
@kof kof merged commit 429c406 into main Jul 12, 2024
13 checks passed
@kof kof deleted the paste-from-webflow branch July 12, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants