Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Move rate-limit to cloudflare #3710

Merged
merged 2 commits into from
Jul 15, 2024
Merged

build: Move rate-limit to cloudflare #3710

merged 2 commits into from
Jul 15, 2024

Conversation

istarkov
Copy link
Member

Description

Move rate-limit to cloudflare

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env file

@istarkov istarkov force-pushed the rate-limit.staging branch from f923bbc to 7819f94 Compare July 15, 2024 13:02
@istarkov istarkov temporarily deployed to postgres_production July 15, 2024 13:02 — with GitHub Actions Inactive
@istarkov istarkov merged commit 3cf1d2b into main Jul 15, 2024
21 checks passed
@istarkov istarkov deleted the rate-limit.staging branch July 15, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants