Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: URL patterns should not be included in the sitemap #3380

Merged
merged 1 commit into from
May 19, 2024
Merged

fix: URL patterns should not be included in the sitemap #3380

merged 1 commit into from
May 19, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented May 19, 2024 •
edited
Loading

Description

URL patterns should not be included in the sitemap. For instance, before this PR, we included paths like /:slug in the sitemap.

Steps for reproduction

Open

https://fix-sitemap-slug.staging.webstudio.is/builder/8404e444-093d-4e70-b5c2-03fd89b9eb6d?pageId=EksrLskoGCCreyVN4xp2r

See dynamic page is excluded

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov changed the title Fix URL Pattenrs to be in sitemap Fix URL Patterns to be in sitemap May 19, 2024
@istarkov istarkov changed the title Fix URL Patterns to be in sitemap fix: URL Patterns must not exist in sitemap May 19, 2024
@istarkov istarkov requested a review from TrySound May 19, 2024 07:43
@istarkov istarkov marked this pull request as ready for review May 19, 2024 07:43
@istarkov istarkov changed the title fix: URL Patterns must not exist in sitemap fix: URL patterns should not be included in the sitemap May 19, 2024
@istarkov istarkov merged commit f47455b into main May 19, 2024
45 of 49 checks passed
@istarkov istarkov deleted the fix-sitemap-slug.staging branch May 19, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istarkov @kof @TrySound