Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Slow performance on a large site during text editing #3351

Merged
merged 1 commit into from
May 14, 2024
Merged

fix: Slow performance on a large site during text editing #3351

merged 1 commit into from
May 14, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented May 13, 2024 •
edited
Loading

Description

Update edited element on blur

https://fast-canvas-edit.development.webstudio.is/builder/ab3439dc-8eab-4050-a5b4-71247fba7d4c

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov requested a review from TrySound May 13, 2024 19:43
kof
kof approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works, very excited about this fix 🎉

@kof kof changed the title fix: Fast canvas edit fix: Slow performance on a large site during text editing May 14, 2024
@istarkov istarkov merged commit 36d477e into main May 14, 2024
21 of 41 checks passed
@istarkov istarkov deleted the fast-canvas-edit.staging branch May 14, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TrySound TrySound TrySound approved these changes

@kof kof kof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@istarkov @kof @TrySound