Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix breakpoints editor layout #3345

Merged
merged 1 commit into from
May 12, 2024
Merged

fix: Fix breakpoints editor layout #3345

merged 1 commit into from
May 12, 2024

Conversation

kof
Copy link
Member

@kof kof commented May 12, 2024

Description

  1. What is this PR about (link the issue and add a short description)

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof kof requested a review from TrySound May 12, 2024 07:02
@kof kof merged commit 8aca480 into main May 12, 2024
29 checks passed
@kof kof deleted the breakpoint-editor-laouyt branch May 12, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants