-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: refactor the style-layer-list for layers based sections in style-panel #3328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
JayaKrishnaNamburu
changed the title
Refactor style panel
chore: refactor the style-layer-list for layers based sections in style-panel
May 8, 2024
JayaKrishnaNamburu
temporarily deployed
to
development
May 8, 2024 12:48 — with
GitHub Actions
Inactive
JayaKrishnaNamburu
temporarily deployed
to
development
May 9, 2024 09:50 — with
GitHub Actions
Inactive
JayaKrishnaNamburu
changed the title
chore: refactor the style-layer-list for layers based sections in style-panel
refactor: refactor the style-layer-list for layers based sections in style-panel
May 9, 2024
JayaKrishnaNamburu
temporarily deployed
to
development
May 9, 2024 09:52 — with
GitHub Actions
Inactive
|
|
JayaKrishnaNamburu
temporarily deployed
to
development
May 10, 2024 11:50 — with
GitHub Actions
Inactive
now text-shadow works now, must have hit something special |
kof
approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need @TrySound 's review?
kof
reviewed
May 10, 2024
apps/builder/app/builder/features/style-panel/style-layers-list.tsx
Outdated
Show resolved
Hide resolved
kof
reviewed
May 10, 2024
apps/builder/app/builder/features/style-panel/style-layers-list.tsx
Outdated
Show resolved
Hide resolved
Not mandatory actually, just moved things around and deleted duplicate code 👍🏽 |
…t.tsx Co-authored-by: Oleg Isonen <[email protected]>
JayaKrishnaNamburu
temporarily deployed
to
development
May 10, 2024 16:08 — with
GitHub Actions
Inactive
…t.tsx Co-authored-by: Oleg Isonen <[email protected]>
JayaKrishnaNamburu
temporarily deployed
to
development
May 10, 2024 16:08 — with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the values in style-panel that handles complex values. Properties like
box-shadow
,text-shadow
,filter
,backdrop-filter
,transition
handles multiples values which needs to be displayed as list. And then allow users to edit them using a content panel. This PR removes all the individual layers of each property and created a common layer list item.Steps for reproduction
Code Review
Before requesting a review
Before merging