Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: refactor the style-layer-list for layers based sections in style-panel #3328

Merged
merged 16 commits into from
May 10, 2024

Conversation

JayaKrishnaNamburu
Copy link
Contributor

@JayaKrishnaNamburu JayaKrishnaNamburu commented May 8, 2024

Description

This PR refactors the values in style-panel that handles complex values. Properties like box-shadow, text-shadow, filter, backdrop-filter, transition handles multiples values which needs to be displayed as list. And then allow users to edit them using a content panel. This PR removes all the individual layers of each property and created a common layer list item.

Steps for reproduction

  1. Add values to all the sections,
  2. Re-order the layers between the values of each property.
  3. Deploy / Export the project.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)

@JayaKrishnaNamburu JayaKrishnaNamburu changed the title Refactor style panel chore: refactor the style-layer-list for layers based sections in style-panel May 8, 2024
@JayaKrishnaNamburu JayaKrishnaNamburu changed the title chore: refactor the style-layer-list for layers based sections in style-panel refactor: refactor the style-layer-list for layers based sections in style-panel May 9, 2024
@JayaKrishnaNamburu JayaKrishnaNamburu marked this pull request as ready for review May 9, 2024 09:55
@JayaKrishnaNamburu JayaKrishnaNamburu requested review from kof and TrySound May 9, 2024 09:55
@JayaKrishnaNamburu JayaKrishnaNamburu self-assigned this May 9, 2024
@kof
Copy link
Member

kof commented May 9, 2024

  • can't add 2 text shadow layers, adding second deletes the first

@kof
Copy link
Member

kof commented May 9, 2024

  • backdrop filter is still in the advanced panel by default, needs to be removed, we only have there things by default which are not in the base panel

@JayaKrishnaNamburu
Copy link
Contributor Author

JayaKrishnaNamburu commented May 10, 2024

  • can't add 2 text shadow layers, adding second deletes the first

Will take a look, i actually managed to add multiple of them in local 🤔
Screenshot 2024-05-10 at 17 07 02

@kof
Copy link
Member

kof commented May 10, 2024

now text-shadow works now, must have hit something special

Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need @TrySound 's review?

@JayaKrishnaNamburu
Copy link
Contributor Author

Do you need @TrySound 's review?

Not mandatory actually, just moved things around and deleted duplicate code 👍🏽

@JayaKrishnaNamburu JayaKrishnaNamburu merged commit cfe222c into main May 10, 2024
27 of 29 checks passed
@JayaKrishnaNamburu JayaKrishnaNamburu deleted the refactor-style-panel branch May 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants