Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form action in case of undefined should use Remix Form to avoid reload #3327

Merged
merged 1 commit into from
May 7, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented May 7, 2024

Description

Form action in case of undefined should use Remix Form to avoid page reload

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov requested review from TrySound and kof May 7, 2024 22:38
@istarkov istarkov merged commit b770a51 into main May 7, 2024
27 of 29 checks passed
@istarkov istarkov deleted the fix-form branch May 7, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants