Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add doctype to new/edit page #3314

Merged
merged 1 commit into from
May 6, 2024
Merged

feat: Add doctype to new/edit page #3314

merged 1 commit into from
May 6, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented May 6, 2024

Description

ref: #3308

Use for review:

image image

In case of xml is selected

  • No way to make xml as home page
image image
  • Editing of social/etc is disabled
image

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@kof
Copy link
Member

kof commented May 6, 2024

Btw what happens if someone uses XML on a page that has things like radix components or literally anything non-xml?

@istarkov istarkov requested a review from TrySound May 6, 2024 15:27
@istarkov istarkov requested a review from TrySound May 6, 2024 17:36
@istarkov istarkov merged commit cd76fe4 into main May 6, 2024
33 checks passed
@istarkov istarkov deleted the add-xml-doc-type branch May 6, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants