Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Simplify development by fixing dev mode image behavior, fix migrate cli #3310

Merged
merged 2 commits into from
May 6, 2024

Conversation

istarkov
Copy link
Member

@istarkov istarkov commented May 6, 2024

Description

  • Remove vite overlay Error about image not exists in dev mode (replacing 500 on
  • Add prisma package directory as cwd to all prisma commands

Steps for reproduction

  1. click button
  2. expect xyz

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

@istarkov istarkov changed the title Fix-dev-tools build: Fix development tools vite and migrate May 6, 2024
@istarkov istarkov changed the title build: Fix development tools vite and migrate build: Simplify development by fixing dev mode image behavior, fix migrate cli May 6, 2024
@istarkov istarkov requested a review from TrySound May 6, 2024 10:18
@istarkov istarkov merged commit fd9bf61 into main May 6, 2024
31 of 33 checks passed
@istarkov istarkov deleted the fix-dev-tools branch May 6, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants