Skip to content

Commit

Permalink
fix: hide background mode from the user in vimeo component (#4618)
Browse files Browse the repository at this point in the history
## Description

This mode is a combination of loop and autoplay and controls, so one can
make it, currently its confusing because it doesn't affect these
controls when toggling it


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
  • Loading branch information
kof authored Dec 18, 2024
1 parent 7a1daca commit 88217ac
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/sdk-components-react/src/vimeo.ws.ts
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,9 @@ const initialProps: Array<keyof ComponentProps<typeof Vimeo>> = [
"className",
"url",
"quality",
"loading",
"showPreview",
"autoplay",
"loading",
"backgroundMode",
"doNotTrack",
"loop",
"muted",
Expand Down

0 comments on commit 88217ac

Please sign in to comment.