Skip to content

Commit

Permalink
fix: Movement jumps on windows (#4296)
Browse files Browse the repository at this point in the history
## Description

Seems like 
closes #4236

For me bug on windows looks a little bit different like a huge scrubbing
jumps. But anyway seems like fixed everything described in corresponding
issue.


## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
  • Loading branch information
istarkov authored Oct 16, 2024
1 parent 89bca4d commit 87e2a1c
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ const requestPointerLock = (
// other browsers show a warning banner, making the use of it in this scenario subpar: in which case we fallback to using non-pointerLock means:
// albeit without an infinite cursor ux.
if (shouldUsePointerLock) {
targetNode.requestPointerLock();
// @ts-expect-error - unadjustedMovement is a chromium only feature, fixes random movementX|Y jumps on windows
targetNode.requestPointerLock({ unadjustedMovement: true });
const cursorNode = (targetNode.ownerDocument.querySelector(
"#numeric-guesture-control-cursor"
) ||
Expand Down

0 comments on commit 87e2a1c

Please sign in to comment.