Skip to content

Commit

Permalink
fix: fix bindings panel placement (#4640)
Browse files Browse the repository at this point in the history
## Description

Accidentally positioned on the right instead of left

Also fixes shfit+P and shift+E when pressed in the inputs 
webstudio-is/webstudio-community#208
#4638

## Steps for reproduction

1. click button
2. expect xyz

## Code Review

- [ ] hi @kof, I need you to do
  - conceptual review (architecture, feature-correctness)
  - detailed review (read every line)
  - test it on preview

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
0000)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env` file
  • Loading branch information
kof authored Dec 21, 2024
1 parent 1670ea5 commit 21a97fb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion apps/builder/app/builder/shared/binding-popover.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ export const BindingPopover = ({
const valueError = validate?.(evaluateExpressionWithinScope(value, scope));
return (
<FloatingPanel
placement="right-start"
placement="left-start"
open={isOpen}
onOpenChange={(newOpen) => {
// handle special case for popover close
Expand Down
4 changes: 4 additions & 0 deletions apps/builder/app/builder/shared/commands.ts
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,17 @@ export const { emitCommand, subscribeCommands } = createCommandsEmitter({
handler: () => {
$publishDialog.set("publish");
},
disableHotkeyOnFormTags: true,
disableHotkeyOnContentEditable: true,
},
{
name: "openExportDialog",
defaultHotkeys: ["shift+E"],
handler: () => {
$publishDialog.set("export");
},
disableHotkeyOnFormTags: true,
disableHotkeyOnContentEditable: true,
},
{
name: "toggleComponentsPanel",
Expand Down

0 comments on commit 21a97fb

Please sign in to comment.