-
-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update getting started guide #1160
base: master
Are you sure you want to change the base?
Conversation
This adds a few minor changes to fix the fact that the existing getting started steps actually fail to compile.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use sass-loader without style-loader and css-loader, we have Examples
to provide different cases
Fair enough, but the starting guide explicitly uses style-loader and css-loader in its webpack config, it just doesn't install them in the prior steps and that causes the getting started steps to not work. Seems those steps should work ideally, no? I'm not trying to argue with you, just making sure it's not overlooked :) If I'm on the wrong track, happy to have you're recommendation on how to handle this. Just trying to leave things better than I found them. If you want something changed let me know and I'll be happy to update this PR w/ master and make any changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we need to have the readme examples as simple as possible. We can rather have explicit examples elsewhere.
Agreed. I'd like to help make the readme example work - I'm just not sure how to do that in a way the maintainers want. Let me know if there's some way that I can help here. |
Let's add an extra small section with |
This adds a few minor changes to fix the fact that the existing getting started steps actually fail to compile.
This PR contains a:
Motivation / Use-Case
Currently if you follow the steps in the Getting Starting section of the readme you'll end up with a configuration that fails to compile. This makes a few minor changes to the steps such that, when followed, they will successfully compile. Additional details below.
Breaking Changes
There are no breaking changes.
Additional Info
Here are the steps in a terminal running the existing readme "Getting Started" steps:
We can fix the errors with these steps (there are other ways obviously, but these steps are a minimal set of changes keeping in spirit with a "Getting Started" guide):
Install
style-loader
per the error and try again:Now install
css-loader
per the error and try again:Now, below is a console session with the proposed changes: