Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppressing the waitForTcp and checkTcpPort exceptions as it only hindered debugging #167

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Suppressing the waitForTcp and checkTcpPort exceptions as it only hindered debugging #167

wants to merge 1 commit into from

Conversation

PaulLodge
Copy link
Collaborator

No description provided.

@PaulLodge PaulLodge marked this pull request as draft August 3, 2023 14:52
@PaulLodge PaulLodge requested a review from sgala August 3, 2023 14:52
sgala
sgala approved these changes Aug 6, 2023
View reviewed changes
Copy link
Contributor

@sgala sgala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me, the stacktrace doesn't realy add value, and with the changes we will reduce noise and contribute to smaller logs when the server doesn't start

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgala sgala sgala approved these changes

Assignees

@AdamKrajcik AdamKrajcik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulLodge @sgala @AdamKrajcik