[LayoutNG] Skip "replaced % resolution" quirk on ortho-roots. #17381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jun 18, 2019
This is about an undocumented quirk. I raised whatwg/quirks#46 for it. LayoutNG currently cannot handle this situation, because we don't store the inline-size to use in replaced percentage resolution (only the block-size). However, I find it hard to believe that there'd be any specific expectations to how this is supposed to work if a table cell has a definite block-size, and a descendant establishes an orthogonal writing-mode root. So just ignore it and use regular percentage size resolution in these cases. Bug: 967069 Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075 Reviewed-by: Ian Kilpatrick <[email protected]> Reviewed-by: Christian Biesinger <[email protected]> Commit-Queue: Morten Stenshorne <[email protected]> Cr-Commit-Position: refs/heads/master@{#670126}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1664075
branch
from
7e9aa74 to
a0ea38f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about an undocumented quirk. I raised
whatwg/quirks#46 for it.
LayoutNG currently cannot handle this situation, because we don't store
the inline-size to use in replaced percentage resolution (only the
block-size). However, I find it hard to believe that there'd be any
specific expectations to how this is supposed to work if a table cell
has a definite block-size, and a descendant establishes an orthogonal
writing-mode root. So just ignore it and use regular percentage size
resolution in these cases.
Bug: 967069
Change-Id: Iac61abe80f4f949017cc161855b2223ec4503812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1664075
Reviewed-by: Ian Kilpatrick <[email protected]>
Reviewed-by: Christian Biesinger <[email protected]>
Commit-Queue: Morten Stenshorne <[email protected]>
Cr-Commit-Position: refs/heads/master@{#670126}