Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): use new release workflow #592

Merged
merged 6 commits into from
Dec 23, 2024
Merged

chore(CI): use new release workflow #592

merged 6 commits into from
Dec 23, 2024

Conversation

chenjiahan
Copy link
Member

Summary

The new release workflow is the same as Rsbuild and Rspress, see https://github.com/web-infra-dev/rsbuild/blob/main/.github/workflows/release.yml.

GITHUB_TOKEN is no longer required in this workflow.

bench-pr.yml is deleted. We can add it back if it still need to be used.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on web-infra-dev/rsbuild@058993d, is there a need to restrict the "latest" dist-tag to only trigger on the main branch? This would prevent packages from being published before a PR is merged, meaning that publishing an npm package would require review by others to prevent accidental publishing.

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #592 will not alter performance

Comparing release_workflow_1223 (3c813cf) with main (ac486b9)

Summary

✅ 5 untouched benchmarks

@fi3ework
Copy link
Member

Based on web-infra-dev/rsbuild@058993d, is there a need to restrict the "latest" dist-tag to only trigger on the main branch? This would prevent packages from being published before a PR is merged, meaning that publishing an npm package would require review by others to prevent accidental publishing.

Because other PRs may be merged after the merge and before the release, we cannot guarantee that the commit being released is the final release commit. We can adjust our approach in the future based on the situation.

@chenjiahan chenjiahan merged commit 97b02ac into main Dec 23, 2024
17 checks passed
@chenjiahan chenjiahan deleted the release_workflow_1223 branch December 23, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants