Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add alias replace externals tests in bundleless mode #581

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

Timeless0911
Copy link
Collaborator

@Timeless0911 Timeless0911 commented Dec 19, 2024

Summary

In bundleless mode, since there is no bundling concept, all modules will be externalized, so we will automatically replace the aliases in resolve.alias with output.externals to ensure the final output is generated correctly.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 7958314
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/676932783f53850008d6f94a
😎 Deploy Preview https://deploy-preview-581--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Dec 19, 2024

CodSpeed Performance Report

Merging #581 will not alter performance

Comparing test/alias-externals (bd09c42) with main (ac486b9)

Summary

✅ 5 untouched benchmarks

Copy link
Member

@fi3ework fi3ework left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to also add new test cases that rewritten with resolve.alias of the cases under tests/integration/externals/browser which is using output.externals now, since we're might encourage user to use resolve.alias first in the future.

website/docs/en/config/rsbuild/resolve.mdx Outdated Show resolved Hide resolved
website/docs/zh/config/rsbuild/resolve.mdx Outdated Show resolved Hide resolved
@Timeless0911
Copy link
Collaborator Author

Do we need to also add new test cases that rewritten with resolve.alias of the cases under tests/integration/externals/browser which is using output.externals now, since we're might encourage user to use resolve.alias first in the future.

This case is a bundle case, so I add bundleless tests with resolve.alias in tests/integration/alias tests.

@fi3ework fi3ework merged commit 4416f02 into main Dec 23, 2024
17 checks passed
@fi3ework fi3ework deleted the test/alias-externals branch December 23, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants