Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Caching #14

Merged
merged 2 commits into from
Apr 11, 2017
Merged

Add Caching #14

merged 2 commits into from
Apr 11, 2017

Conversation

wbyoung
Copy link
Owner

@wbyoung wbyoung commented Apr 11, 2017

This addresses issues of concern in #1, and may or may not resolve that issue entirely.

The cache is not quite ideal at the moment since it's not based on the contents of the postcss.config.js file, but this is a good step forward.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b6ec645 on caching into 3d377ed on master.

@wbyoung wbyoung merged commit 06a0527 into master Apr 11, 2017
@wbyoung wbyoung deleted the caching branch April 11, 2017 01:38
@wbyoung
Copy link
Owner Author

wbyoung commented Apr 11, 2017

Oh, it's also worth noting here… the cache is on disk, though it was originally attempted to be made in memory since a server could be long-running (as indicated in #1). Unfortunately, this didn't work with a simple use case, running under nodemon because nodemon kills the process tree which means the server we run is killed off every time nodemon notices the process needs to restart. Arguably, this is a bug in nodemon, but they specifically added this feature, and it would just cause conflicts to suggest that nodemon be run in a specific way in order to use this plugin, so it's probably better to just go with what they have and expect/allow the server to be killed off while keeping a cache around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants