Fix legacy facts, api config and tidy formatting

[pearsondavid]

Fixes #1160

[jorussell1]

Okay I've tested this on Debian and windows. I was mistakenly using puppet agent version 8.10 on debian, which would cause puppet agent to fail to read any of the legacy facts and this patch fixed that, but switching to 7.34.0 on Debian resolved this issue as well.

On Windows however this patch fails

Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Evaluation Error: Error while evaluating a Function Call, This ossec module has not been tested on your distribution. (file: /etc/p uppetlabs/code/environments/fixlegacyfacts/modules/wazuh/manifests/repo.pp, line: 105, column: 16) on node windows

Here's the output of puppet facts os on the node for which this fails
{ "os": { "architecture": "x64", "family": "windows", "hardware": "x86_64", "name": "windows", "release": { "full": "11", "major": "11" }, "windows": { "display_version": "23H2", "edition_id": "Professional", "installation_type": "Client", "product_name": "Windows 10 Pro", "release_id": "23H2", "system32": "C:\\WINDOWS\\system32" } } }

The puppet agent version is 7.32.1 on the windows node that fails

[sarhaynes]

You should update the metadata.json file to state that this now supports puppet 8 and to include the later versions of the dependencies as this change is related to those changes. See Issue #1173.