-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS SDK Setup #2299
Merged
Merged
TS SDK Setup #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
force-pushed
the
filip-ts-sdk-setup
branch
from
September 18, 2024 17:54
02afc25
to
f14b617
Compare
sodic
commented
Oct 7, 2024
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/StarterTemplates/Templating.hs
Show resolved
Hide resolved
sodic
commented
Oct 7, 2024
Martinsos
reviewed
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, did a quick shallow review, let's take of stuff that is important for release, and the rest we can do after it!
For release, what I think is most important is two comments:
- How easy it is for them to set up the project to be able to use TS SDK. Existing or new project.
- Is it ok that we pollute their package.json with mention of wasp-config package, and that we have that in our basic template.
waspc/cli/src/Wasp/Cli/Command/CreateNewProject/StarterTemplates/Templating.hs
Show resolved
Hide resolved
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for reviewers
You can ignore the todos (they're mostly notes for me and I'll soon be moving them somewhere else).
You can comment on them if you want, but it isn't necessary.
The
wasp ts-setup
command is unfinished (more on that below). We can discuss how functional it has to be before the release.Context
This PR is complementary to #2276.
It contains the changes that enable the user to create and work in a TS SDK project that looks like this:
Those changes include:
wasp-config
packages that servers as an API for both our users andwaspc
.wasp ts-setup
command that sets up the project to work with a config in TypeScript (TS SDK).It's just the blue parts from this graph plus the prep work necessary for making the whole thing functional. The idea is to review this PR by treating the purple parts as a black box (that part is covered in #2276).