Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using TS SDK from
waspc
#2276Using TS SDK from
waspc
#2276Changes from 34 commits
e228263
664eafe
1b75ab9
0c7b901
b7c4800
68bfe30
0758747
b7ecab4
e2e802e
2d27900
987243d
15e3e68
7600288
2b0c0ff
7ec9356
1597f4b
b887cd8
1bdc871
52378c4
115dce5
2617b6f
32275e5
b673308
3513b68
e9ef283
0dc7435
3e9efc8
24f65ec
edd7a85
ae76820
7eab0bc
8c8cb4f
d0ba9e5
4eec3c1
1699df2
5a6719e
3f48b98
67f1f9e
522e131
8ab0b3f
d90b235
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't have something like
data WaspFile
, so that we could doPath' Abs (File WaspFile)
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. We didn't before, but we'll have it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take care of this later. It requires dealing with cyclic dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solved in #2407