Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BatchRandTransform & PitchShift #24

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

warner-benjamin
Copy link
Owner

Resolves #23.

@vishalbakshi
Copy link

vishalbakshi commented May 7, 2024

@warner-benjamin I tested this on Kaggle and it works as expected:

# installing from the transfom_fixes branch
!pip install colorednoise primePy git+https://github.com/warner-benjamin/fastxtend.git@transform_fixes -qq

auds.summary(df) runs successfully when the DataBlock has PitchShift as batch_tfms:

image

Ran auds.summary with batch_tfms equal to VolumeBatch, PitchShiftTA, TimeStretch and PitchShiftOrTimeStretch and it works. Also trained a resnet18 for a few epochs just to make sure and it trains successfully.


My first preference was to test it locally on my machine so I got fastxtend cloned and installed (w/ pip install -e .) but I have macOS 11.6 so I was getting the following error when running auds.summary(df):

RuntimeError: The MPS backend is supported on MacOS 12.3+.Current OS version can be queried using `sw_vers`

Which I don't think can be resolved until I upgrade to 12.3+.

@warner-benjamin warner-benjamin merged commit 7c52688 into main May 7, 2024
10 checks passed
@warner-benjamin
Copy link
Owner Author

@vishalbakshi thanks for testing the fix. I wouldn't expect fastxtend to work on MPS. I've coded everything with Cuda or CPU in mind, and don't have a modern mac to do any testing on.

@warner-benjamin warner-benjamin deleted the transform_fixes branch May 7, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError When Using TensorAudio Batch Transforms
2 participants