Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#39] null as forced default value #40

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[#39] null as forced default value #40

wants to merge 2 commits into from

Conversation

nagarajanchinnasamy
Copy link
Contributor

For more details, please refer to issue: [#39] null as forced default value

@wankdanker
Copy link
Owner

@nagarajanchinnasamy Please add tests exercising the proposed functionality. Thank you!

@nagarajanchinnasamy
Copy link
Contributor Author

You are welcome. I will add the tests and resubmit.

@nagarajanchinnasamy
Copy link
Contributor Author

Tests added. Please review. Thanks 👍

@nagarajanchinnasamy
[wankdanker#39] null as forced default value
50ae568 
[wankdanker#39] null as forced default value

[wankdanker#39] null as forced default value
@nagarajanchinnasamy
Copy link
Contributor Author

commits squashed into one.

@greghawk
Copy link

@nagarajanchinnasamy Did this ever get merged? I have same issue. One would expect a non-source key to never output

@YuriBarssi
Copy link

Good question. Are you guys merging this one @wankdanker ? Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nagarajanchinnasamy @wankdanker @greghawk @YuriBarssi