Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix database instance flag #183

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: Fix database instance flag #183

merged 2 commits into from
Dec 2, 2024

Conversation

flamarion
Copy link
Contributor

Based on the docs, it should be a lowercase string

Error: Error, failed to create instance sa-gcp-social-walrus: googleapi: Error 400: Value requested is not valid. Failed to set binlog_row_image: MINIMAL was not an expected string., invalidFlagValue

   with module.wandb.module.database.google_sql_database_instance.default,
   on .terraform/modules/wandb/modules/database/main.tf line 47, in resource "google_sql_database_instance" "default":
   47: resource "google_sql_database_instance" "default" {

After fixing it the DB creation went through.

@flamarion flamarion requested a review from a team as a code owner December 2, 2024 09:07
@flamarion flamarion requested review from danielpanzella and removed request for a team December 2, 2024 09:07
@zacharyblasczyk zacharyblasczyk merged commit a9329dd into main Dec 2, 2024
6 checks passed
@zacharyblasczyk zacharyblasczyk deleted the fix_database_instance_flag branch December 2, 2024 15:09
jsbroks pushed a commit that referenced this pull request Dec 2, 2024
@semantic-release-bot
chore(release): version 6.2.1 [skip ci]
a1a24ee 
### [6.2.1](v6.2.0...v6.2.1) (2024-12-02)

### Bug Fixes

* Fix database instance flag ([#183](#183)) ([a9329dd](a9329dd))
@jsbroks
Copy link
Member

jsbroks commented Dec 2, 2024

This PR is included in version 6.2.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharyblasczyk zacharyblasczyk zacharyblasczyk approved these changes

@danielpanzella danielpanzella Awaiting requested review from danielpanzella

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flamarion @jsbroks @zacharyblasczyk