feat: Shift around some values and actually enable user supplied bucket access secrets

[danielpanzella]

No description provided.

[annirudh]

Applies for me are failing with the following after this PR:

{"level":"error","ts":"2024-12-14T07:17:01Z","msg":"Failed to apply config changes.","controller":"weightsandbiases","controllerGroup":"apps.wandb.com","controllerKind":"WeightsAndBiases","WeightsAndBiases":{"name":"wandb","namespace":"default"}
,"namespace":"default","name":"wandb","reconcileID":"66845a56-b5d7-4449-bb23-e329787b6d7d","error":"cannot patch \"wandb-executor\" with kind Deployment: Deployment.apps \"wandb-executor\" is invalid: spec.template.spec.containers[0].env[24].val
ueFrom.secretKeyRef.key: Required value","errorVerbose":"cannot patch \"wandb-executor\" with kind Deployment: Deployment.apps \"wandb-executor\" is invalid: spec.template.spec.containers[0].env[24].valueFrom.secretKeyRef.key: Required value\nhe
lm.sh/helm/v3/pkg/kube.(*Client).Update\n\t/go/pkg/mod/helm.sh/helm/[email protected]/pkg/kube/client.go:441\nhelm.sh/helm/v3/pkg/action.(*Upgrade).releasingUpgrade\n\t/go/pkg/mod/helm.sh/helm/[email protected]/pkg/action/upgrade.go:378\nruntime.g
oexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1598","stacktrace":"github.com/wandb/operator/controllers.(*WeightsAndBiasesReconciler).Reconcile\n\t/workspace/controllers/weightsandbiases_controller.go:249\nsigs.k8s.io/controller-runtime/pkg/int
ernal/controller.(*Controller).Reconcile\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k
8s.io/[email protected]/pkg/internal/controller/controller.go:323\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/co
ntroller.go:274\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:235"}

[dacbd]

Can you share the values.yaml of ~ `global.bucket` or `global.defaultBucket`?

…

On Sat, Dec 14, 2024, 16:22 Annirudh Prasad ***@***.***> wrote: Applies for me are failing with the following after this PR: {"level":"error","ts":"2024-12-14T07:17:01Z","msg":"Failed to apply config changes.","controller":"weightsandbiases","controllerGroup":"apps.wandb.com","controllerKind":"WeightsAndBiases","WeightsAndBiases":{"name":"wandb","namespace":"default"} ,"namespace":"default","name":"wandb","reconcileID":"66845a56-b5d7-4449-bb23-e329787b6d7d","error":"cannot patch \"wandb-executor\" with kind Deployment: Deployment.apps \"wandb-executor\" is invalid: spec.template.spec.containers[0].env[24].val ueFrom.secretKeyRef.key: Required value","errorVerbose":"cannot patch \"wandb-executor\" with kind Deployment: Deployment.apps \"wandb-executor\" is invalid: spec.template.spec.containers[0].env[24].valueFrom.secretKeyRef.key: Required ***@***.******@***.***/pkg/action/upgrade.go:378\nruntime.g ***@***.******@***.***/pkg/action/upgrade.go:378%5Cnruntime.g> oexit\n\t/usr/local/go/src/runtime/asm_amd64.s:1598","stacktrace":"github.com/wandb/operator/controllers.(*WeightsAndBiasesReconciler).Reconcile\n\t/workspace/controllers/weightsandbiases_controller.go:249\nsigs.k8s.io/controller-runtime/pkg/int ***@***.***/pkg/internal/controller/controller.go:122\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/go/pkg/mod/sigs.k ***@***.******@***.******@***.***/pkg/internal/controller/co ***@***.******@***.***/pkg/internal/controller/co> ***@***.***/pkg/internal/controller/controller.go:235 ***@***.***/pkg/internal/controller/controller.go:235>"} — Reply to this email directly, view it on GitHub <#279 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIN7MZITB3E6Z5I6MWTRWD2FPMDTAVCNFSM6AAAAABTLYS4JSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBSHEZDOMRWHE> . You are receiving this because you commented.Message ID: ***@***.***>