Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support ClickHouse and Kafka passwords as secret key variables #267

Merged
merged 7 commits into from
Dec 19, 2024
Merged

Added support ClickHouse and Kafka passwords as secret key variables #267

merged 7 commits into from
Dec 19, 2024

Conversation

amanpruthi
Copy link
Contributor

No description provided.

@velotioaastha velotioaastha linked an issue Nov 27, 2024 that may be closed by this pull request
Feature Request | Support ClickHouse and Kafka passwords as secret key variables wandb/terraform-aws-wandb#307
Closed
@abhinavg6 abhinavg6 requested a review from theishshah December 9, 2024 16:34
theishshah
theishshah approved these changes Dec 9, 2024
View reviewed changes
Copy link
Contributor

@theishshah theishshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chart updates look good, appear to building correctly in test env

@velotioaastha velotioaastha merged commit 9177b04 into main Dec 19, 2024
1 of 2 checks passed
@velotioaastha velotioaastha deleted the issue-307 branch December 19, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theishshah theishshah theishshah approved these changes

@jsbroks jsbroks Awaiting requested review from jsbroks jsbroks is a code owner

@vanpelt vanpelt Awaiting requested review from vanpelt vanpelt is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request | Support ClickHouse and Kafka passwords as secret key variables
3 participants
@amanpruthi @theishshah @velotioaastha