Update execution options APIs #529
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #529 +/- ##
==========================================
- Coverage 72.83% 72.83% -0.01%
==========================================
Files 46 46
Lines 6789 6803 +14
Branches 1305 1304 -1
==========================================
+ Hits 4945 4955 +10
- Misses 1287 1295 +8
+ Partials 557 553 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -32,9 +32,8 @@ def _make_binary_executable(self): | |||
| raise FileNotFoundError(f"Binary not found at {binary_path}") | |||
| binary_path.chmod(binary_path.stat().st_mode | stat.S_IEXEC) | |||
|
|
|||
| def run_simulation(self, input_filename: str, output_filename: str, options: str): | |||
| command = [str(self.execution_options.binary_path), "-i", input_filename, "-o", output_filename] | |||
| command.extend(options.split(' ')) | |||
There was a problem hiding this comment.
This line was contributed by bubbel and needs to be removed if they do not agree to new license
|
This PR aims to remove code contributed by Brubbel but refactors in the process |
waltsims
requested review from
faridyagubbayli
and removed request for
faridyagubbayli
|
@waltsims given that the user has given consent, do we still need this PR? |
|
@faridyagubbayli it improves the apis and removes extra spaces from the option strings. These improvements are still useful in my opinion |
waltsims
changed the title
Removes changes from user brubbel in case that they do not give concent for relicensing.