Blind attempt to fix Chrome>55 touchscreen behaviour #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@IvanSanchez thanks a lot! Currently I have no device to check it, I will merge it as soon as I will try it out |
|
@IvanSanchez fyi seems that this commit breaks drag functionality in case of mouse devices. would you pls double-check whether this symptom is real or not? |
|
Were the any tests telling if it worked or not? |
|
does anyone have a device to check it? |
|
I´ve tested with Chrome 59 on Huawei P9 Lite and hasn´t fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a blind (read: completely untested) attempt to fix #29. Listening to
PointerEvents whenL.Browser.pointeris true should alleviate all the problems. Hopefully this will not break other touchscreens.